BuildServiceProvider should return IServiceProvider instead of ServiceProvider

Question

BuildServiceProvider should return IServiceProvider instead of ServiceProvider

cknaap opened this issue 7 years ago · comments

Method Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider returns a ServiceProvider instead of the associated interface IServiceProvider.

The latter allows for better mocking in unit tests.

Plus, the documentation on the method also says it returns IServiceProvider.

David Fowler · Answer 1 · Mon Nov 27 2017 23:53:29 GMT+0800 (China Standard Time)

No, it shouldn't. How can you mock an extension method? This method is about building a concrete implementation of an IServiceProvider.

Plus, the documentation on the method also says it returns IServiceProvider.

It was changed in 2.0 and needs to be updated /cc @Rick-Anderson

ASP.NET Hello Bot · Answer 2 · Mon Jan 01 2018 15:23:47 GMT+0800 (China Standard Time)

This issue was moved to dotnet/aspnetcore#2329