Improve the circular dependency exception message

Question

Improve the circular dependency exception message

AndriySvyryd opened this issue 7 years ago · comments

Andriy Svyryd commented 7 years ago

Currently it says A circular dependency was detected for the service of type 'MyType'.

It should provide all types in the cycle.

Eilon Lipton · Answer 1 · Thu Sep 21 2017 05:56:48 GMT+0800 (China Standard Time)

You mean like this?

A circular dependency was detected for the service of type that has a circular dependency was detected for the service of type that has a circular dependency was detected for the service of type that has a circular dependency was detected for the service of type that has a circular dependency was detected for the service of type that has a circular dependency was detected for the service of type that has a circular dependency was detected for the service of type that has a circular dependency was detected for the service of type that has a circular dependency was detected for the service of type that has a circular dependency.?

Andriy Svyryd · Answer 2 · Thu Sep 21 2017 06:02:52 GMT+0800 (China Standard Time)

@Eilon Sounds perfect, as I always say - redundancy leads to clarity.

Eilon Lipton · Answer 3 · Sat Oct 14 2017 00:38:49 GMT+0800 (China Standard Time)

@pakrym I'm assigning to you to resolve when #592 is merged.