Not able to build for --prod

Question

Not able to build for --prod

inanmadak opened this issue 6 years ago · comments

This issue persists. If I do squeezebox/dist it fails on ng build --prod saying @NgModule tag or strange private public property error.

If I do just squeezebox import withd just 'squeezebox' build works but, then ng serve fails.

These occur independently from tsconfig includes or excludes. So either I can ng build or ng serve not both by using the same import style.

ng build error:
node_modules/squeezebox/tests/index.component.ts.AppComponent.html(4,27): : Property 'itemsList' is private and only accessible within class 'AppComponent'

ng serve error:
ERROR in ./node_modules/squeezebox/index.ts
Module build failed: Error: /Users/username/Code/myproject/node_modules/squeezebox/index.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.
The missing file seems to be part of a third party library. TS files in published libraries are often a sign of a badly packaged library. Please open an issue in the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).

Alejandro Soto · Answer 1 · Mon Apr 23 2018 22:57:14 GMT+0800 (China Standard Time)

mm thanks for that feedback, wondered why picking test code in the build will take a look

Inan · Answer 2 · Mon May 07 2018 17:21:52 GMT+0800 (China Standard Time)

@asotog hey, any progress on this? Waiting for your comments/fixes.

Inan · Answer 3 · Wed May 16 2018 16:01:05 GMT+0800 (China Standard Time)

@asotog Please givesome feedback, we need to do a production build. Could you at least remove tests for the current build so that we can use ng build --prod at least.

Alejandro Soto · Answer 4 · Wed May 16 2018 22:01:36 GMT+0800 (China Standard Time)

can you please provide exact angular version you are using ? taking a look now, assuming you are on latest and using cli

Inan · Answer 5 · Wed May 16 2018 22:22:25 GMT+0800 (China Standard Time)

CLI: 1.7.3
angular: 5.2.9

Alejandro Soto · Answer 6 · Wed May 16 2018 22:41:59 GMT+0800 (China Standard Time)

Wait why you are not using dist ?

import {SqueezeBoxModule} from 'squeezebox/dist';

version 1.4.0

Inan · Answer 7 · Wed May 16 2018 23:10:34 GMT+0800 (China Standard Time)

dist gives test error, and ng serve does not work. Without dist, ng build does not work gives NgModule error. If i do dist and change your test code variable itemList to public then it works, kinda I hope. iOS için Outlook<https://aka.ms/o0ukef> uygulamasını edinin

…

________________________________ From: Alejandro Soto <notifications@github.com> Sent: Wednesday, May 16, 2018 5:42:04 PM To: asotog/squeezebox Cc: Inan; Author Subject: Re: [asotog/squeezebox] Not able to build for --prod (#19) Wait why you are not using dist ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#19 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKMya0HLyEBRTOmHoSIeBZUP-QezP52Nks5tzDq8gaJpZM4Tfnd9>.

Alejandro Soto · Answer 8 · Wed May 16 2018 23:16:55 GMT+0800 (China Standard Time)

just published another version please try updating, got rid of private accessor type

Inan · Answer 9 · Thu May 17 2018 20:37:44 GMT+0800 (China Standard Time)

Okay thanks it is working right now. It is without dist. when we import with 'squeezebox/dist' it gives below error, even though I am doing NgModule import:

ERROR in : Unexpected value 'SqueezeBoxModule in /Users/inan/Code/project-name/node_modules/squeezebox/dist/index.d.ts' imported by the module 'AppModule in /Users/inan/Code/project-name/src/app/app.module.ts'. Please add a @NgModule annotation.

Thanks again.

Alejandro Soto · Answer 10 · Thu May 17 2018 22:28:59 GMT+0800 (China Standard Time)

well you have to use ng module annotations aren't you ? like :

@NgModule({
  imports:      [BrowserModule, SqueezeBoxModule], // here

Inan · Answer 11 · Thu May 24 2018 15:06:24 GMT+0800 (China Standard Time)

I am already doing that. Currently without 'squeezebox/dist', I can use it for both ng serve and ng build --prod. dist is the problem. I think this version is fine, but here is my feedback anyway so that you can investigate why it is not working with dist.

Miguel Suarez · Answer 12 · Fri Jan 18 2019 10:36:30 GMT+0800 (China Standard Time)

I'm also getting this error, I can't compile for staging environment:

ng build --configuration=staging

I get the error:

Error: C:\Users\user\Projects\project\node_modules\squeezebox\index.ts is missing from the TypeScript compilation. Please make sure it is in your tsconfig via the 'files' or 'include' property.

But doing an:

ng build

Builds without any errors.

Using:

Angular CLI: 7.0.3
Node: 8.11.2
OS: Windows 10 x64
Angular: 7.0.2

Alejandro Soto · Answer 13 · Sat Jan 19 2019 06:56:36 GMT+0800 (China Standard Time)

@kaoz70 can you please attach your tsconfig ?

Miguel Suarez · Answer 14 · Sat Jan 19 2019 09:19:59 GMT+0800 (China Standard Time)

Sure:

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "module": "es2015",
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "es5",
    "typeRoots": [
      "node_modules/@types"
    ],
    "lib": [
      "es2018",
      "dom"
    ]
  }
}