replace int(oversampling_factor) with round(oversampling_factor)
MaryumSayeed opened this issue · comments
Relevant Materials
Description
The int() function around oversampling_factor causes oversampling_factor to be 0 if it's less than 1 crashing the code. Solution: replace int() with round().
Computing
Please provide (by editing) the following information:
- OS: macOS
- Version: 5.9.4
- Implementation: command line
Attachments
In order to reproduce the issue from our end, please provide both the light curve and power spectrum for the relevant target!
Attach the required data files here and if applicable, any figures or screenshots to help explain your problem.
Other
Add any other relevant information here (e.g., links to related issues or solutions)
See highlighted line in code:
https://github.com/ashleychontos/pySYD/blob/master/src/pysyd/target.py#L365-L371
Summary Checklist:
- How were you using
pySYD
when you experienced the issue?- CLI
- API
- jupyter
- Did you provide all the relevant information and files so that we can reproduce the error?
- Yes
- No
- Did you check if the issue has already been reported?
- Yes
→ Was there a proposed workaround or solution?- Yes
- No
- Idk
- No
- Yes
- Do you know if the issue is version specific?
- Yes*
- - [] No
- Idk
- Have you identified a workaround or solution?
- Yes*
- No
- Will you be submitting a pull request associated with this issue?
- Yes
- No
- Idk
* If you selected 'Yes' for any of these points, please expand on each of them in more detail below.
Note: If you found any relevant threads, questions, solutions or are submitting a pull request, please remember to provide links for any/all as these are incredibly helpful for future users.
This is now fixed in pysyd v6.10.5