Giters

aseemk / zoomit-lightbox

Zoom.it-powered Lightbox — an infinitely better experience for hi-res images.

Home Page:http://aseemk.github.io/zoomit-lightbox/test/gallery.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

HTML should use unique IDs instead of classes?

aseemk opened this issue · comments

commented

Right now we give our overall container a unique ID (#zoomit-lightbox), but all the elements inside it have generic (though semantic) classnames (like background, foreground, info, etc.). This means there's a potential chance for collision and CSS conflicts. Should we make all those unique IDs too? (E.g. #zoomit-lightbox-background, etc.)