asdf-vm / asdf-plugin-template

📦 asdf-vm plugin template with GitHub Actions and more!

Home Page:https://asdf-vm.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Plugin template doesn't follow asdf "Golden Rules for Plugin Scripts"

booniepepper opened this issue · comments

Describe the bug

The plugin template is violating the asdf project's "golden rules" for portability

Most specifically it's using echo and source liberally, and these have been considered "banned commands" for more than a year. (I understand these are bash scripts and can make assumptions but... still!)

Steps to reproduce

read the source, or generate the template

Expected behavior

No golden rule violations. In fact I'd expect the template to be enforcing this as part of linting?

Screenshots

Additional context

https://github.com/asdf-vm/asdf/blame/fce6c534daf6c0b2eed7dc633b18f7b87f665d2f/test/banned_commands.bats#L5-L24