asdf-format / asdf

ASDF (Advanced Scientific Data Format) is a next generation interchange format for scientific data

Home Page:http://asdf.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

deprecate `AsdfSpec` and `format_tag`

braingram opened this issue · comments

AsdfSpec (based off of SimpleSpec from semantic_version) is effectively unused.

It is referenced once in format_tag:

if isinstance(version, AsdfSpec):
version = str(version.spec)

format_tag has only a single use in asdf:
tag = asdf.testing.helpers.format_tag("stsci.edu", "asdf", "1.0.0", "fits/fits")

where a spec is not provided.

The format_tag use can be replaced by an f-string.

One motivation for deprecating AsdfSpec is that it provides unexpected version comparisons: see #1772