arwes / arwes

Futuristic Sci-Fi UI Web Framework.

Home Page:https://arwes.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

support React 18

amir-arad opened this issue · comments

I can't upgrade to React 18 due to typescript errors with Arwes

Describe the solution you'd like

Support React 18 types

Describe alternatives you've considered

for now I dont upgrade React. no biggie

Additional context

some example errors:

Type '{ children: (string | number | Element)[]; animator: { duration: { enter: number; exit: number; }; activate: boolean; }; }' is not assignable to type 'IntrinsicAttributes & TextProps & WithAnimatorOutputProps'.
  Property 'children' does not exist on type 'IntrinsicAttributes & TextProps & WithAnimatorOutputProps'.

64             <Text animator={{ duration, activate: broken }}>
                ~~~~

Type '{ children: Element[]; }' has no properties in common with type 'IntrinsicAttributes & ArwesThemeProviderProps'.

115                 <ArwesThemeProvider>
                     ~~~~~~~~~~~~~~~~~~
                     
Type '{ children: Element; audioSettings: { common: { volume: number; }; }; playersSettings: { object: { src: string[]; }; type: { src: string[]; loop: boolean; }; }; bleepsSettings: { object: { player: string; }; type: { ...; }; }; }' is not assignable to type 'IntrinsicAttributes & BleepsProviderProps'.
  Property 'children' does not exist on type 'IntrinsicAttributes & BleepsProviderProps'.

117                     <BleepsProvider
                         ~~~~~~~~~~~~~~

Et cetera

a full printout can be found here. and the source is this PR.

commented

Is there any latest progress?

@cryptosunshine , not yet released, still work in progress.

may be related: also support the new Typescript :(
starwards/starwards#1351

The project was migrated completely to TypeScript and support for only React v18. Though the development is still in progress with the releases made with the next tag on NPM. Let me know if you have any questions on Discord 😄