TOS isn't being applied

Question

TOS isn't being applied

tiagogaspar8 opened this issue 2 years ago · comments

Tiago Gaspar commented 2 years ago

libtorrent version (or branch): 2.0.5 (in qbittorrent)

platform/architecture: Windows 11

compiler and compiler version: N/A

please describe what symptoms you see, what you would expect to see instead and
how to reproduce it.

The TOS doesn't seem to be applying correctly, it is configured to 4 by default but in wireshark the DSCP isn't changed and stays at CS0 (0).
I'd also like to suggest the change from the name TOS to DSCP since TOS is deprecated.

Thanks!

Arvid Norberg commented 2 years ago

#6822

Arvid Norberg commented 2 years ago

#6874

Arvid Norberg · Answer 1 · Sun Apr 17 2022 19:14:43 GMT+0800 (China Standard Time)

did you look at all traffic or just some connections?
I believe DSCP is only meant to apply to peer connections, not DHT or tracker connections for instance.

Arvid Norberg · Answer 2 · Mon Apr 18 2022 17:18:17 GMT+0800 (China Standard Time)

are you looking at both TCP and UDP peer connections? The DSCP is set via slightly different code paths for those.

Arvid Norberg · Answer 3 · Mon Apr 18 2022 17:22:25 GMT+0800 (China Standard Time)

do you see the SET_TOS messages in the log?

Tiago Gaspar · Answer 4 · Mon Apr 18 2022 19:29:06 GMT+0800 (China Standard Time)

Hi,

My setup only has μtp enabled, and that doesn't have any dscp, I can't say about TCP, but I believe I can try if you'd like!

Calum Lind · Answer 5 · Wed May 18 2022 04:10:51 GMT+0800 (China Standard Time)

@arvidn This rename has broken compatibility and generating errors in Deluge with latest lt 1.2 code, was this applied to the wrong branch (for 2.0 not 1.2) and missing setting deprecated in settings_pack.cpp?

self.session.apply_settings(settings)
builtins.KeyError: 'unknown name in settings_pack: peer_tos'

Arvid Norberg · Answer 6 · Wed May 18 2022 05:24:16 GMT+0800 (China Standard Time)

good point. I need to fix the binding to support the old name as well.

Tiago Gaspar · Answer 7 · Tue Jun 21 2022 20:14:40 GMT+0800 (China Standard Time)

Hi @arvidn , I'd just like to let you know that TCP also suffers from the same issue, dscp isn't marked

Arvid Norberg · Answer 8 · Tue Jun 21 2022 20:38:07 GMT+0800 (China Standard Time)

is it possible the process need a special privilege to set it?
Do you have any error messages in the log for setting DSCP?

Tiago Gaspar · Answer 9 · Sat Jul 02 2022 00:24:11 GMT+0800 (China Standard Time)

I have tried to run it as an admin but it didn't help

Arvid Norberg · Answer 10 · Sat Jul 02 2022 01:18:56 GMT+0800 (China Standard Time)

@tiagogaspar8 can you get the log? Do you see entries saying SET_TOS or SET_DSCP? If so, they will contain error codes.

Tiago Gaspar · Answer 11 · Sat Jul 02 2022 02:00:05 GMT+0800 (China Standard Time)

I'm using qbittorrent and I have no idea how to enable extra debug logging 😞
Do you have any idea?

mzz · Answer 12 · Sun Aug 20 2023 20:03:44 GMT+0800 (China Standard Time)

In the implementation of libtorrent, dscp/tos is always set after the application handshake instead of the TCP handshake. This behavior breaks possibility of traffic split via tos by proxy, because the traffic split in proxy application always happens at the moment TCP syn=1.

We have to solve the problem with some inelegant methods, see daeuniverse/dae#295.

The tos setting is wonderful, but the current timing of the option setting is preventing it from being used, hope you can fix it, thanks!