arvidn / libtorrent

an efficient feature complete C++ bittorrent implementation

Home Page:http://libtorrent.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Possible `deprecation/compatibility` issues with `RC_1_2` & use of `OpenSSL 3.x`

xavier2k6 opened this issue · comments

Please provide the following information

libtorrent version (or branch): 1.2.15 & RC_1_2

platform/architecture: Windows

compiler and compiler version: Visual Studio Enterprise 2022 | 17.1.32328.378

please describe what symptom you see, what you would expect to see instead and
how to reproduce it.

Possible deprecation/compatibility issues with RC_1_2 & use of OpenSSL 3.x

[warning]D:\a\qBittorrent\qBittorrent\libtorrent\src\hasher.cpp(53): warning C4996: 'SHA1_Init': Since OpenSSL 3.0
[warning]D:\a\qBittorrent\qBittorrent\libtorrent\src\hasher.cpp(105): warning C4996: 'SHA1_Update': Since OpenSSL 3.0
[warning]D:\a\qBittorrent\qBittorrent\libtorrent\src\hasher.cpp(125): warning C4996: 'SHA1_Final': Since OpenSSL 3.0
[warning]D:\a\qBittorrent\qBittorrent\libtorrent\src\hasher.cpp(141): warning C4996: 'SHA1_Init': Since OpenSSL 3.0

&

[warning]D:\a\qBittorrent\qBittorrent\libtorrent\src\hasher512.cpp(53): warning C4996: 'SHA512_Init': Since OpenSSL 3.0
[warning]D:\a\qBittorrent\qBittorrent\libtorrent\src\hasher512.cpp(93): warning C4996: 'SHA512_Update': Since OpenSSL 3.0
[warning]D:\a\qBittorrent\qBittorrent\libtorrent\src\hasher512.cpp(113): warning C4996: 'SHA512_Final': Since OpenSSL 3.0
[warning]D:\a\qBittorrent\qBittorrent\libtorrent\src\hasher512.cpp(129): warning C4996: 'SHA512_Init': Since OpenSSL 3.0

Edit:

"RelWithDebInfo"

2.0.5 & RC_2_0 seem to be unaffected.

Reference: https://github.com/xavier2k6/qBittorrent/actions/runs/2166952552

I will work on this issue.

please note that this affects ABI. There needs to be a new build option and a new inline namespace for using the new OpenSSL API.

@xavier2k6 Can I ask how did you made Visual Studio display those warnings? I built the whole library + the tests and examples. But I didn't get any warnings.

@arvidn I can't get Visual Studio to show deprecation warnings. I built the library but didn't get any warnings. I even converted the cmake project into a Visual Studio project and built the project again. But no warnings again.

@mohammad-ghasemi-dev check out my original post, CI builds on windows are built partially with vcpkg

Sorry. I can't do it right now. I'm in the admission process of a day job and have to focus on the things they need. Also I need a little more on-the-job experience before I can contribute to libtorrent. But certainly I'll be back later to help. Because in my personal project I use libtorrent. But I don't know exactly when it would be.