Remove the cpp11 tag on Github

Question

Remove the cpp11 tag on Github

vstumpf opened this issue 3 years ago · comments

Vincent Stumpf commented 3 years ago

There's a cpp11 tag in the About window of the repo, yet it doesn't actually support c++11.

Can you please remove it.

Arun Muralidharan · Answer 1 · Thu Feb 25 2021 10:54:37 GMT+0800 (China Standard Time)

I am not sure what you mean by it doesn't support C++11. The code does not compile without atleast C++11 standard.

Vincent Stumpf · Answer 2 · Thu Feb 25 2021 10:56:49 GMT+0800 (China Standard Time)

The README says

Support for C++11 seems trivial based on the changes required. Why not support C+11 then ?

Its 2018 now! If I ever start getting requests to have support for C++11, then I will surely consider it.

Is this no longer the case?

Arun Muralidharan · Answer 3 · Thu Feb 25 2021 11:00:39 GMT+0800 (China Standard Time)

Good catch. I really don't remember what is that about :). It certainly uses C++11 features, no doubt. Maybe I meant using C++14/17 std::string_view et al instead of hand rolled one. I will update the README.