artsy / palette

Artsy's design system

Home Page:https://palette-storybook.artsy.net/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Firefox updates to palette

samchieng opened this issue · comments

Noticed a few issues with palette components on Firefox. These are the ones @erikdstock noticed but we might want to go through an audit and see if there's anything else that's Firefox related.

Add font smoothing styles to palette typography for Firefox

It appears that firefox isn’t applying font smoothing styles to some palette components. Here you can see it especially on the title and button text in this modal I’m working on. (Firefox | Chrome)

image

Checkbox style shows two checkboxes on Firefox

2019-07-12 12 36 41

Can't agree to COS on Firefox Mobile

2019-07-18 16 08 25

commented

Just realized that the last example[ Can't agree to COS on Firefox Mobile ] is from old styles, not palette!

Look into more cross-browser testing

commented

Just realized that the first example (authentication modal) is actually a more custom checkbox in reaction, so this may be entirely unrelated to palette!

Yep. Neither of these components are from Palette. There's definitely still some weirdness that needs to be sorted out in those relevant apps, but there's nothing to do in Palette for this issue.