Include ability to scan multiple sources

Question

Include ability to scan multiple sources

arthurpalves opened this issue 4 years ago · comments

Tim Studt · Answer 1 · Mon Mar 01 2021 16:09:03 GMT+0800 (China Standard Time)

wouldn't it make sense to support in .yml:

sources:
  - Sources/
  - Modules/**/Sources
  - ./*.swift

PathKit already supports globs so shouldn't be too big of a task.

Arthur Alves · Answer 2 · Mon Mar 01 2021 16:32:05 GMT+0800 (China Standard Time)

I plan to make a new release in 2 weeks. Will try to squeeze this one in there.
Or is this something you'd like to contribute to?

Tim Studt · Answer 3 · Mon Mar 01 2021 16:38:08 GMT+0800 (China Standard Time)

I can give it a try.
but it can get to a bigger task when considering fail scenarios, e.g. missing files/path.. so I'd start with a simple solution.
also it'd be better to have the yml parsing part unit tested first, that would increase implementation speed on dependant features IMO.

Arthur Alves · Answer 4 · Mon Mar 01 2021 16:51:04 GMT+0800 (China Standard Time)

Yes, that is the plan. I'm just tight on time.
There are probably some refactoring that needs to be done in order to unit test it properly as well.

Any help you can give is appreciated, otherwise I'll take a look when I get some time 🙌

Tim Studt · Answer 5 · Fri Mar 12 2021 21:59:34 GMT+0800 (China Standard Time)

#52 PR waiting for review

Arthur Alves · Answer 6 · Sat Mar 13 2021 02:24:50 GMT+0800 (China Standard Time)

Awesome, Tim!
I'll have time to take a look tomorrow morning.