Great theme - needs a little correction.
sharu725 opened this issue · comments
The theme looks great @artemsheludko . But it makes an api call! I tried to see why and this is what I found in view source
<li class="github"><a href="http://github.com/{
--
| "api_url": "https://api.github.com",
| "baseurl": "/flexible-jekyll",
| "build_revision": "52f93ec6c5f6233eb77fc6770d396ba164a42b51",
| "clone_url": "https://github.com/artemsheludko/flexible-jekyll.git",
| "contributors": [
| {
| "login": "artemsheludko",
| "id": 22279513,
| "avatar_url": "https://avatars3.githubusercontent.com/u/22279513?v=4",
| "gravatar_id": "",
| "url": "https://api.github.com/users/artemsheludko",
| "html_url": "https://github.com/artemsheludko",
| "followers_url": "https://api.github.com/users/artemsheludko/followers",
| "following_url": "https://api.github.com/users/artemsheludko/following{/other_user}",
| "gists_url": "https://api.github.com/users/artemsheludko/gists{/gist_id}",
| "starred_url": "https://api.github.com/users/artemsheludko/starred{/owner}{/repo}",
| "subscriptions_url": "https://api.github.com/users/artemsheludko/subscriptions",
| "organizations_url": "https://api.github.com/users/artemsheludko/orgs",
| "repos_url": "https://api.github.com/users/artemsheludko/repos",
| "events_url": "https://api.github.com/users/artemsheludko/events{/privacy}",
| "received_events_url": "https://api.github.com/users/artemsheludko/received_events",
| "type": "User",
| "site_admin": false,
| "contributions": 4
| }
.
.
.
There are a lot more lines. It can be a serious performance issue.
Curiously, the problem is solved if I fill the field in the _config.yml
.
There was nothing wrong in the code though. Probably Jekyll interprets empty {{site.github}}
in a different way or something.
You're right. Thank you for participating.