artem-zinnatullin / qualitymatters

Android Development Culture

Home Page:https://artemzin.com/blog/android-development-culture-the-document-qualitymatters/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dagger Note

vanniktech opened this issue · comments

While running the project locally I got that note.

Note: Generating a MembersInjector or Factory for com.artemzin.qualitymatters.QualityMattersApp. Prefer to run the dagger processor over that class instead.

Should we pay attention to this one?

I don't think it's a problem, I probably saw something about false-positive warnings in Dagger's issues. And we 100% have same warnings in our production apps. Is #qualitymatters the first app where you see such warning?

Yes it is.

So I assume this is a hint to do something better but googling it, only got me here. Any pointers?

Haha :) Not really, if you'll investigate it, please share the results
here!

On Fri, 29 Jan 2016, 22:50 Leo Wandersleb notifications@github.com wrote:

So I assume this is a hint to do something better but googling it, only
got me here. Any pointers?


Reply to this email directly or view it on GitHub
#78 (comment)
.

@artem_zin

Just linking issue created in Dagger 2 for that google/dagger#328

I guess this can be closed in favor of the one we created at Google's dagger project?

Let's leave it for now, I'd prefer to close it when we'll fix it in qualitymatters too :)

Closing since we don't @Inject anymore into application class

Yup, thanks!