Error in set Generator
Pwelling opened this issue · comments
Patrick commented
When i set the generator faker with another locale (I want to use nl_NL) it is allways replaced by the default one:
` public function setGenerator($generator)
{
if ($generator !== null) {
$this->generator = $generator;
}
if (class_exists('\Faker\Factory')) {
$this->generator = Factory::create();
}
return $this;
}`
Better would be to add a check if the given generator is null
Nekrasov Ilya commented
Hi, I'm on vacation atm. Could you send a PR?
Patrick commented
I will do this weekend!
Patrick commented
PR was sent...
Nekrasov Ilya commented
I've just tweaked some things e97a020 and released version 1.0.3