remainder function giving negative result (af.rem)

[Matus Krajnak]

Hi, I noticed if I calculate reminder function I get:
print(af.rem(af.constant(11,1,1),3))

-1

which should be:

2

[Pavan Yalamanchili]

@matkraj I think you should be looking at af.mod. This behavior is consistent with IEE (check std::remainder)

[Matus Krajnak]

@pavanky Thanks, I got confused because there is no af.mod in arrayfire-python.

[Matus Krajnak]

Probably this needs to be added to arrayfire/arith.py

def mod(lhs, rhs):
    """
    Find the modulus.
    Parameters
    ----------
    lhs : af.Array or scalar
          Multi dimensional arrayfire array or a scalar number.
    rhs : af.Array or scalar
          Multi dimensional arrayfire array or a scalar number.
    Returns
    --------
    out : af.Array
         Contains the moduli after dividing each value of lhs` with those in `rhs`.
    Note
    -------
    - Atleast one of `lhs` and `rhs` needs to be af.Array.
    - If `lhs` and `rhs` are both af.Array, they must be of same size.
    """
    return _arith_binary_func(lhs, rhs, backend.get().af_mod)

[Pavan Yalamanchili]

@matkraj Do you want to send in a review with this change ?

[Matus Krajnak]

pull request #181