arminbiere / cadical

CaDiCaL SAT Solver

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Confusing code: `cubes.status` set twice (?)

sfiruch opened this issue · comments

PVS Studio (https://pvs-studio.com/en/order/for-students/#IDD159822EC6) found this potential problem.

cubes.status is set twice, in immediate succession. res should be 20, so probably no problem - but it's odd nonetheless.

cubes.status = res;

The same thing happens on lines 510/511 too, but in opposite order:

cadical/src/lookahead.cpp

Lines 510 to 511 in e7369b4

cubes.status = 20;
cubes.status = res;

Looks redundant, but not harmful. Also 'lookahhead' is not used much.

Fixed on development and thus in the upcoming release 1.9.2