arminbiere / cadical

CaDiCaL SAT Solver

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

GCC warns about comparison of `this` to `NULL`

tautschnig opened this issue · comments

We received the following bug report in CBMC:

solver.cpp:259:3: error: ‘nonnull’ argument ‘this’ compared to NULL [-Werror=nonnull-compare]

With more recent CaDiCaL versions this is line 261, but the issue persists. I believe this line in the definition of TRACE should just be removed.

The check has been commented out in our internal version in February and with the merge into the master branch and release 1.5.4 this should be fixed now (line 251).