armcha / AutoLinkTextView

AutoLinkTextView is TextView that supports Hashtags (#), Mentions (@) , URLs (http://), Phone and Email automatically detecting and ability to handle clicks.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Question] Why made AutoLinkTextView as final class

aftabsikander opened this issue · comments

commented

I was wondering why you have made AutoLinkTextView as final class which prevent from extending it for further customization. I wanted to extend your view and provide my own implementation for custom fonts.

For now I have fork your library and made these changes, It would be great if you can remove final in next release.

commented

@aftabsikander of course i will remove it, but you can also send me pull request with custom font implementation, to add extra functionality. Thanks!

commented

@armcha Sure I will create it as soon as I get free time, Will create a pull request as well for you soon. I was wondering hash tags and mention tags should be of small size text then the actual text. so I would update that as well.

Please provide your feedback do you want this feature in my pull request ?

commented

@aftabsikander it will be amazing

commented

@aftabsikander in new version AutoLinkTextView.java is no longer final class