armbian / build

Armbian Linux build framework generates custom Debian or Ubuntu image for x86, aarch64, riscv64 & armhf

Home Page:https://www.armbian.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug]: Regression: LVM broken

rvalle opened this issue · comments

What happened?

LVM builds are failing, cryptroot most probably too.

How to reproduce?

ENABLE_EXTENSIONS=lvm

Branch

main (main development branch)

On which host OS are you running the build script and observing this problem?

Ubuntu 22.04 Jammy

Are you building on Windows WSL2?

  • Yes, my Ubuntu/Debian/OtherOS is running on WSL2

Relevant log URL

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Jira ticket: AR-2489

I have identified the main issue:

root_part_uuid="$(blkid -s UUID -o value ${LOOP}p${rootpart})"

the variable "rootdevice" should be used instead.
This is because extensions that transform the rootdevice may need to modify the root device.
fs-cryptoroot-support also modifies rootdevice, so this extension is probably broken too.
I am working on a fix.

There is another issue with LVM volumes not being recognized mid-process, unless they are re-instantiated.

I suspect this issue has to do with the fact that I have updated my desktop Ubuntu version, and LVM subsystem is passed in to the docker image. In any case, re-instantiating cannot cause any possible harm.