Giters

arkon / ng-sidebar

[Inactive] Angular sidebar component.

Home Page:https://echeung.me/ng-sidebar

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

trapFocus only works on mode 'over'

danielcollettepb opened this issue · comments

commented

In the demo page, set the trapFocus to true, and the mode to push or slide. Tabbing through sidebar items is not trapped and will focus elements in the page.

Tabbing through the sidebar should be trapped like the 'over' mode.

image

trap-focus

Can the check for _isModeOver be removed here:

https://github.com/arkon/ng-sidebar/blob/master/src/sidebar.component.ts#L399