Date parsing deviates from Chrome

Question

Date parsing deviates from Chrome

emirkin opened this issue 11 years ago · comments

Best shown by example:

phantomjs> new Date("May 8")
"Invalid Date"
phantomjs> new Date("May 8 2013")
"2013-05-08T07:00:00.000Z"

In Chrome, both strings are parsed into the same date. Thoughts?

James M. Greene · Answer 1 · Wed Mar 20 2013 02:29:07 GMT+0800 (China Standard Time)

We've had to deal with WebKit Date parsing bugs in the past, this is likely just another one of those. Search the issue tracker for "date" to see more of these.

Eugene Mirkin · Answer 2 · Wed Mar 20 2013 02:32:03 GMT+0800 (China Standard Time)

No doubt. This exact case (ie "when year missing") doesn't seem to be addressed.

Vitaly Slobodin · Answer 3 · Wed Mar 20 2013 02:33:44 GMT+0800 (China Standard Time)

Actually, May 8 is invalid date format according to spec (ISO 8601) and EcmaScript (http://es5.github.com/#x15.9.1.15).
But, this will be resolved in 2.0 release (after upgrading to Qt5 and the latest WebKit version).
Related issue: #10187

Eugene Mirkin · Answer 4 · Wed Mar 20 2013 02:47:26 GMT+0800 (China Standard Time)

Good to know!
When is 2.0 roughly expected?

James M. Greene · Answer 5 · Wed Mar 20 2013 02:52:46 GMT+0800 (China Standard Time)

Assuming we can pull off the Qt 5.0 upgrade in a single release cycle (as
planned), then PhantomJS 2.0 will be released on June 21, 2013.

Sincerely,
James Greene

On Tue, Mar 19, 2013 at 1:47 PM, Eugene Mirkin notifications@github.comwrote:

Good to know!
When is 2.0 roughly expected?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11151#issuecomment-15135115
.

James M. Greene · Answer 6 · Sun Jun 30 2013 10:24:35 GMT+0800 (China Standard Time)

@zicjin: We love the enthusiasm but that alone won't help us get PhantomJS 2.0 out the door any faster. If you want to see it ready sooner, dive in and lend a hand!

Kevin Parkerson · Answer 7 · Tue Nov 05 2013 10:42:05 GMT+0800 (China Standard Time)

If it helps at all, I've found phantomjs spits out 'Invalid Date' when attempting to use a timeZone offset other than 'Z'. For example:

window.console.log(new Date('2050-03-31T00:00:00-0500'));

That will output 'Invalid Date', while this works just fine:

window.console.log(new Date('2050-03-31T00:00:00Z'));

Doesn't help me solve the issue of my unit tests bombing in phantomjs when they shouldn't be, but figured I'd might as well share.

Ken Baltrinic · Answer 8 · Sun Nov 24 2013 19:26:08 GMT+0800 (China Standard Time)

Don't know if this will help you but I found this issue while researching another PhantomJS date parsing problem we were having. To fix ours I completed a polyfill that "successfully" overrides Date.parse and the Date contructor. I say "sucessfully" because of course, the constructor override is necessarily a hack. It solves our issue and I though you might be able to tweak to address yours. YMMV

https://github.com/kbaltrinic/PhantomJS-DatePolyfill

Greg Larrenaga · Answer 9 · Fri Feb 21 2014 03:45:59 GMT+0800 (China Standard Time)

+1 Running into the same issue.

new Date(120).toLocaleTimeString('en-US', {hour12: true});

expected: 4:00:00 PM
actual: 16:00:00

Kevin Crawford · Answer 10 · Thu May 15 2014 03:34:28 GMT+0800 (China Standard Time)

@kevinparkerson's interim solution worked perfectly for me, thanks!

Matt Fehskens · Answer 11 · Tue Sep 02 2014 11:25:03 GMT+0800 (China Standard Time)

thanks @kevinparkerson I thought I could do that, but you just confirmed it for me!

James Delibas · Answer 12 · Tue Sep 30 2014 16:15:42 GMT+0800 (China Standard Time)

Think I found another one.

new Date("2034-03-25");

Expected
Sat Mar 25 2034 00:00:00 GMT+0000 (GMT Standard Time)
PhantomJS
Fri Mar 24 2034 00:00:00 GMT+0000 (GMT Standard Time)

Thomas Upton · Answer 13 · Wed Oct 01 2014 00:58:15 GMT+0800 (China Standard Time)

@jdelibas Is the machine you're testing on in a timezone that's behind GMT? I get similar output in Chrome. It's implicitly adding "T00:00Z" – i.e. it's assuming GMT – and then returning the date in whatever timezone your environment thinks it is. I think that's expected, and not the same bug as here.

What is the same bug is if you try to specify a timezone other than GMT in phantomjs:

phantomjs> new Date("2034-03-25T00:00-0500")
"Invalid Date"
phantomjs> new Date("2034-03-25T00:00Z")
"2034-03-24T00:00:00.000Z"

In Chrome:

> new Date("2034-03-25T00:00-0500")
Sat Mar 25 2034 00:00:00 GMT-0500 (CDT)
> new Date("2034-03-25T00:00Z")
Fri Mar 24 2034 19:00:00 GMT-0500 (CDT)

Note that Chrome displays the date in my local timezone, even though I created it using GMT.

My rule of thumb is that any date without a timezone is inherently wrong or at the very least incomplete. That's why this bug is such a hassle, but at least converting everything to GMT is a valid, if tedious, workaround.

Joe Nudell · Answer 14 · Fri Jun 26 2015 00:49:16 GMT+0800 (China Standard Time)

@jdelibas that one appears to be https://bugs.webkit.org/show_bug.cgi?id=130123. Able to reproduce in Phantom 2.

David I. Lehn · Answer 15 · Tue Jan 03 2017 05:56:56 GMT+0800 (China Standard Time)

PhantomJS 2.1.1 still has the WebKit bug referred to by @jnu. It was fixed in WebKit on 2014-03-14. Parsed dates from 2034-03-01 to 2100-02-28 are wrong.

phantomjs> new Date('2034-02-28')       
"2034-02-28T00:00:00.000Z"
phantomjs> new Date('2034-03-01')
"2034-02-28T00:00:00.000Z"
phantomjs> new Date('2100-02-28')
"2100-02-27T00:00:00.000Z"
phantomjs> new Date('2100-03-01')
"2100-03-01T00:00:00.000Z"

William Wall · Answer 16 · Fri Jan 06 2017 04:51:01 GMT+0800 (China Standard Time)

We are still seeing date inconsistencies with Chrome for the following values (the local timezone is -0700):

phantomjs> new Date('2014-01-30 12:34:56')
Invalid Date
phantomjs> new Date('2014-01-30T12:34:56+0000')
Invalid Date
phantomjs> new Date('2014-01-30T12:34:56-0700')
Invalid Date

Chrome parses those as:

2014-01-30T19:34:56Z
2014-01-30T12:34:56Z
2014-01-30T19:34:56Z

Adam Merrifield · Answer 17 · Sat Jan 14 2017 04:53:19 GMT+0800 (China Standard Time)

I'm glad I found this thread. I've been trying to render a page with charts on it, and you can imagine how many Date objects get used. Nothing was working, I thought I was going crazy until I ran:

phantom> new Date('2017-01-13 01:14')
Invalid Date

WAT?

Wouter · Answer 18 · Mon Mar 27 2017 16:24:52 GMT+0800 (China Standard Time)

We're using the beta Phantom 2.5 build and dates are still fucked up so the Qt update did nothing to fix any of that. Trying to compare dates (somedate < currdate) to see which one is in the past works 1 out of 5 runs... We're running jasmine on top of Phantom so our tests are becoming flaky due to this issue.

Any progress or updates?

Alessandro · Answer 19 · Tue Apr 11 2017 14:42:10 GMT+0800 (China Standard Time)

Running BackstopJS (which is using PhantomJS to work) and I encountered this error as well and I can't take diff screenshots of certain pages anymore.

Any updates?

Karl Tiedt · Answer 20 · Wed Jan 03 2018 01:42:08 GMT+0800 (China Standard Time)

Consider this the semi annual, "it is still broken and some feedback would be amazing" comment.

William Wall · Answer 21 · Wed Jan 03 2018 02:23:06 GMT+0800 (China Standard Time)

@ktiedt try headless Chrome/Firefox instead. I believe the addition of that flag to those browsers has rendered this project obsolete.

https://developers.google.com/web/updates/2017/04/headless-chrome
https://developer.mozilla.org/en-US/Firefox/Headless_mode

Karl Tiedt · Answer 22 · Wed Jan 03 2018 02:30:55 GMT+0800 (China Standard Time)

@wallw-bits yeah after posting, I learned that Phantom is no more, thanks for the links, those I had not come across yet.

stale · Answer 23 · Sat Dec 28 2019 22:55:14 GMT+0800 (China Standard Time)

Due to our very limited maintenance capacity (see #14541 for more details), we need to prioritize our development focus on other tasks. Therefore, this issue will be automatically closed. In the future, if we see the need to attend to this issue again, then it will be reopened. Thank you for your contribution!