[BUG] Hang on startup during CPU detection due to °C unit in temperature readout
gsuberland opened this issue · comments
If the sensors
command is not available, the Python get_sensors()
function is called instead. That function returns temperature values with "°C" appended:
Lines 4899 to 4903 in 60f95a1
However, it seems that the unit is not properly removed from temperature values, causing an error on startup:
/usr/local/bin/bashtop: line 2151: (33°C-20)*100/(cpu[temp_high]-20) : syntax error: invalid arithmetic operator (error token is "°C-20)*100/(cpu[temp_high]-20) ")
This hangs bashtop in a 100% CPU loop, and a second session has to be opened to kill the process.
The error site is:
Line 2151 in 60f95a1
The bug is probably in the Intel CPU package temperature code (and may also exist in the AMD code too), and my guess would be that the trailing unit isn't cut off, but my bash-fu isn't good enough to figure out exactly where the issue arises.
Info:
- Bashtop version: 0.9.25
- OS: TrueNAS CORE (FreeBSD 13.1)
- Psutil version: 5.9.4
- Bash version: 5.2.15
- Terminal: PuTTY, invoking bashtop from tcsh 6.22.04