themeum / kirki

Extending the customizer

Home Page:https://kirki.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Typography control returns both 'subset' and 'subsets' indexes with the same value

opened this issue · comments

Issue description:

get_theme_mod returns both 'subset' and 'subsets' indexes
selection_003
but should have the same structure as default value

Because of that, this solution #537 (comment) does not work

Version used:

(Did you try using the develop branch from github? There's a chance your issue has already been adressed there)
Version 2.3.1

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

[
                'settings' => 'layout_color_example1',
                'label' => esc_html__('Example 1', 'cf47rs'),
                'type' => 'typography',
                'default' => [
                    'font-family' => 'Roboto',
                    'variant' => 'regular',
                    'font-size' => '14px',
                    'line-height' => '1.5',
                    'letter-spacing' => '0',
                    'subset' => ['latin-ext'],
                    'color' => '#333333',
                    'text-transform' => 'none',
                    'text-align' => 'left'
                ],
                'output' => [
                    [
                        'element' => '.variable-top-border',
                        'property' => 'border-top-width',
                        'units' => 'px',
                    ],
                    [
                        'element' => '.variable-bottom-border',
                        'property' => 'border-bottom-width',
                        'units' => 'px',
                    ],
                ]

            ]

great catch!

Fixed, in 2.3.2 subset becomes subsets.
Pending docs update on #950 as well, docs will be updated once 2.3.2 is released.

Thank you, this plugin is awesome!

On Sun, May 1, 2016, 00:59 Aristeides Stathopoulos notifications@github.com
wrote:

great catch!

Fixed, in 2.3.2 subset becomes subsets.
Pending docs update on #950 #950
as well, docs will be updated once 2.3.2 is released.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#948 (comment)