arielsalminen / feature.js

Feature.js is a fast, simple and lightweight browser feature detection library in 1kb.

Home Page:https://featurejs.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Directly Object

amovah opened this issue · comments

I think Feature function constructor is useless, we should use the Feature Object directly. It can improve the performance of Feature
a little of code:

Feature = {
    css3Dtransform : (function() {
      var test = (!util.old && util.pfx("perspective") !== null);
      return !!test;
    })()
}

and Why should we have the constructor that does nothing?

and I'm interested in fixing this issue.

@amovah This is a good point and might make the library slightly smaller too. Do you want to help achieving this?

Yes, Of course. please assign me and I'll will fix this

@amovah Can you please fork this repository and make a pull request (I can’t assign you here directly)?

I've just forked.

This is now merged and fixed!