Request: Dark mode as opt-in
gregorypratt opened this issue · comments
We don't have an requirements to create a "Dark mode" variant of our website. However when dark mode is preferred certain aspects of the base styles do update due to @media (--OSdark) {.
The prop is fine but could the rules be refactored into an optional "extra" that gives us an opt-in approach, similar to normalise and buttons etc.? Thank you.
are you looking for a light theme only version of normalize? here's a good example on how you can do that, there is a light theme only version you can import instead of the auto-adapting one.
that solve the issue for you? or did i misunderstand something? 🤓
Almost 😄 basically I think it would be nice if it were the other way around, no dark mode within open-props at all as the default, and add a dark mode support as an "extra".
Basically these rules should be part of a new src/extra/dark-mode.css for example.