argyleink / gui-challenges

Components from the YouTube show GUI Challenges: accessible, responsive, adaptive and cross browser components.

Home Page:https://youtube.com/playlist?list=PLNYkxOF6rcIAaV1wwI9540OC_3XoIzMjQ

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dialog height in safari

andredewaard opened this issue · comments

Dialog height in safari defaults to 'fit-content'. Fixed it with an hardcode

dialog {
  height: min-content;
}

Any known complications by doing this?

PS: really nice dialog tutorial btw

oh! i seem to be able to consistently fix it with

dialog {
  max-block-size: max-content;
  height: auto;
}

height: min-content; showed an error in the styles pane that it wasn't valid

there we go, duh, stretching is the default for grid and flexbox, i undid the confusing max-block-size styles in favor of a simple align-content 👍🏻

Thanks! really appreciating your effort to check this out.