Controller sharding docs error
reginapizza opened this issue · comments
Describe the bug
the docs here state that sharding.enabled has a default value of false and sharding.dynamicScalingEnabled has a default value of true (even though in the code it's just a pointer to a bool, so it should have a default value of nil if not set, which would just mean false). It also says sharding.dynamicScalingEnabled will ignore sharing.enabled, so wouldn't that mean that sharding.dynamicScalingEnabled is always enabled even if sharding.enabled is false? It would also be weird to have dynamic sharding enabled by default. I'm assuming that the docs are wrong and the default value should just say false, so filing this as a bug.
As a side note, the documentation here should also be updated: https://developers.redhat.com/articles/2023/09/26/dynamically-scale-argo-cd-application-controller-openshift-gitops-110?extIdCarryOver=true&sc_cid=701f2000001Css5AAC&source=sso#