argonjs / argon-app

Source code for the Argon4 AR Web Browser

Home Page:https://app.argonjs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Can't deploy to Android platform

frank-777777 opened this issue · comments

I tried to deploy this application on the Android platform, including virtual machine and my phone. However, both failed. There are several bugs in the source code. I compiled different branches and used android-url-launch as the target.

Environment:
Windows 10,
Node: 8.12.0,
npm: 6.4.1,
package.json:
{
"nativescript": {
"id": "edu.gatech.ael.argon4",
"tns-android": {
"version": "3.1.1"
},
"tns-ios": {
"version": "3.1.0"
}
},
"dependencies": {
"@argonjs/argon": "^1.3.2",
"argon-web-view": "file:plugins/argon-web-view",
"minimatch": "^3.0.4",
"nativescript-google-analytics": "^0.3.7",
"nativescript-permissions": "^1.2.3",
"nativescript-screen-orientation": "github:argonjs/nativescript-screen-orientation",
"nativescript-vuforia": "file:plugins/nativescript-vuforia",
"speigg-nativescript-geolocation": "0.0.9-patch.0",
"tns-core-modules": "^3.1.0",
"urijs": "^1.17.1"
},
"devDependencies": {
"@types/minimatch": "^2.0.29",
"@types/urijs": "^1.15.31",
"babel-traverse": "6.15.0",
"babel-types": "6.15.0",
"babylon": "6.9.2",
"lazy": "1.0.11",
"nativescript-dev-typescript": "^0.5.0",
"tns-platform-declarations": "^2.4.4",
"nativescript-hook-debug-production": "^1.0.4",
"typescript": "^2.4.1"
}
}

Found 20 errors:

app/components/bookmarks-view/BookmarksView.ts(15,5): error TS6133: 'contentLayout' is declared but its value is never read.
app/components/common/analytics.ts(60,29): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'. Type 'undefined' is not assignable to type 'string'.
app/components/common/AppViewModel.ts(105,43): error TS2339: Property 'RealityViewerFactory' does not exist on type 'typeof import("C:/Users/frank/Desktop/argon-app-an/node_modules/@argonjs/argon/index")'.
app/components/common/argon-device-provider.ts(3,30): error TS2306: File 'C:/Users/frank/Desktop/argon-app-an/node_modules/speigg-nativescript-geolocation/nativescript-geolocation.d.ts' is not a module.
app/components/common/argon-device-provider.ts(32,59): error TS2345: Argument of type 'VisibilityService' is not assignable to parameter of type 'Device'. Property 'owner' is missing in type 'VisibilityService'.
app/components/common/argon-device-provider.ts(125,80): error TS2339: Property '_scratchCartesian' does not exist on type 'NativescriptDeviceService'.
app/components/common/argon-device-provider.ts(168,80): error TS2339: Property '_scratchCartesian' does not exist on type 'NativescriptDeviceService'.
app/components/common/argon-device-provider.ts(285,9): error TS2554: Expected 7 arguments, but got 5.
app/components/common/argon-device-provider.ts(485,22): error TS2339: Property 'configureStage' does not exist on type 'NativescriptDeviceServiceProvider'.
app/components/common/argon-vuforia-provider.ts(173,48): error TS2339: Property 'targetReferenceFrameMap' does not exist on type 'EntityServiceProvider'.

I tried to fix some bugs, but some are confusing for me.

app/components/common/argon-device-provider.ts(3,30): error TS2306: File 'C:/Users/frank/Desktop/argon-app-an/node_modules/speigg-nativescript-geolocation/nativescript-geolocation.d.ts' is not a module.
app/components/common/argon-device-provider.ts(32,59): error TS2345: Argument of type 'VisibilityService' is not assignable to parameter of type 'Device'. Property 'owner' is missing in type 'VisibilityService'.

For the two bugs above, I don't know what to do.

Generally, it is a long-term open source project, some bugs are easily to find. So I intend to believe that I did something wrong and very confused. Can anyone help me figure out? Thanks

@speigg Thanks for reading

Thanks for the report; it's been a while since we compiled the Android version, this may be a result of changes to Typescript or NativeScript. I suspect @speigg doesn't have the cycles for this; if you figure out what's going on, please submit a PR.

I'd love to continue to have the Android version able to build, although we don't have anyone working on it right now; we've been working on a version that's compliant with the upcoming WebXR standard, working on iOS first, and getting the Android version updated would be interesting, too.