Giters

ardalis / Specification

Base class with tests for adding specifications to a DDD model

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update pipelines.

fiseni opened this issue · comments

commented

The workflows are not particularly nice. The publish workflows are triggered on each push, and they fail since the version is not updated. Also, they're more complicated than necessary.

  • We have too many workflows, and this is because we need one for EF6 that runs on a Windows host. If we're having Windows host anyway, then why not run everything on it?
  • Running tests on docker is necessary since we need MSSQL db for integration tests. But, if we're using a Windows host we don't need that. The images come with LocalDb preinstalled.
  • The test reports are also overkill. It was really cool having them in Azure pipelines since we could see the reports in a separate tab. But, we don't have that in GitHub Action and we're compiling them for no reason.
  • The task we have for publishing packages is outdated. Now we have the dotnet nuget push which is way more simpler.

We might have a single workflow ci.yml for build/test and triggered on pr and push on main. And an additional one release.yml which will be triggered on Release, whenever we publish a release on GitHub.