utils/processing methods cannot be called from node.js because of window reference

Question

utils/processing methods cannot be called from node.js because of window reference

bnjm opened this issue 7 years ago · comments

Benjamin Devine commented 7 years ago

To reproduce

call io3d.utils.processing.whenDone from any node.js runtime

Actual result

Thrown error: window is not defined

Expected

Either method to work, or error message like "method not supported from non-browser environments"

Madlaina Kalunder · Answer 1 · Mon Nov 13 2017 22:37:29 GMT+0800 (China Standard Time)

An error message should only be a temporary solution

Benjamin Devine · Answer 2 · Mon Nov 13 2017 22:48:23 GMT+0800 (China Standard Time)

Sorry I did not mean to push to master, but easy fix in fcf5955

Benjamin Devine · Answer 3 · Mon Nov 13 2017 23:35:52 GMT+0800 (China Standard Time)

Since I pushed to master without the chance for a review, I will just explain that the problem was caused by using window.setTimeout instead of setTimeout.

Probably window.setTimeout is nicer to use since it avoids introducing a new global reference, but it throws an error in node.js... also global setTimeout is referenced a few times elsewhere like https://github.com/archilogic-com/3dio-js/blob/master/src/utils/wait.js