Tag versions as proper releases

Question

Tag versions as proper releases

peterhoeg opened this issue 2 years ago · comments

For versions < 0.7, all releases in this repo are tagged as pre-releases, which means our nix tooling isn't able to fetch the tarballs. Is there any chance at the very least that 0.6.4 can be tagged as a proper release?

We can (and should) work around this fact in our crystal tooling on nix, but that's a separate issue.

Peter Hoeg commented 2 years ago

Thanks!

Peter Hoeg · Answer 1 · Fri Mar 25 2022 20:53:55 GMT+0800 (China Standard Time)

Just in case somebody else has the same problem. The workaround is to use shard.override.yml and specify the commit of the version:

---
dependencies:
  email:
    github: arcage/crystal-email
    commit: 3899a238d58ec5ef3fd117d8d47bf122abd8f5c3

ʕ·ᴥ·ʔAKJ · Answer 2 · Sat Mar 26 2022 18:57:02 GMT+0800 (China Standard Time)

There is no firm reason why this shard always in pre-release.

I only couldn't judge it have enough quality for proper release, because I have very few experience in open source development.

Even if "WITHOUT WARRANTY" is emphasized in LICENSE file, I always worry about this shard may includes some critical bugs.

Nevertheless, It's not impossible to uncheck "pre-release" box If such side effect exists.

Although I still cannot ensure the safety this shard.

Peter Hoeg · Answer 3 · Mon Mar 28 2022 18:05:18 GMT+0800 (China Standard Time)

Considering it's used by the lucky framework, I'm sure people would have started shouting if things weren't working.

ʕ·ᴥ·ʔAKJ · Answer 4 · Mon Mar 28 2022 20:05:08 GMT+0800 (China Standard Time)

Thanks.

I have unchecked "pre-release" on v0.6.4 and v0.7.0.

Peter Hoeg · Answer 5 · Tue Oct 11 2022 15:23:24 GMT+0800 (China Standard Time)

This shard gets pulled in by carbon (and thus every lucky project), so it has definitely had some testing. I think it would be safe to tag it as a proper release like you did for 0.7.0 and if there are issues, people will report them.

Peter Hoeg · Answer 6 · Tue Oct 11 2022 16:05:13 GMT+0800 (China Standard Time)

I'm sorry about bringing this back to life. It looks like I initially replied back in March via email to github but it's only now adding it as a comment and thus necro-bumping the issue.