Allow collapsing non-ambiguous operator symbols
aeckert opened this issue · comments
aeckert commented
I have a case where I have a bunch of templated classes that have potentially expensive operator() implementations. However, due to how we collapse names, we never collapse any operators at all and we don't end up grouping these when highlight expensive template instantiation patterns. Relevant code is here:
...
static std::string_view CollapseName(const std::string_view& elt)
{
// Parsing op<, op<<, op>, and op>> seems hard. Just skip'm all
if (elt.find("operator") != std::string::npos)
return elt;
...
I'm wondering if we can change this to only prevent collapsing if we find either 'operator<' or 'operator>' in the name so that we can surface something like this.
ben-craig commented
Seems reasonable. I vaguely recall running into some cases where there were spaces between operator
and the op type.
Put together a PR and we can look at it!