Giters

apricote / Listory

Track your Spotify listens

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

feat: ARM Images

apricote opened this issue · comments

commented

"Requested" in #263

In addition to x86 docker images, I should make sure to also publish ARM images.

commented

First successful image was published in v1.24.2, but now the release pipeline takes 30 minutes vs the 3 minutes it took before.

Issues:

  1. docker buildx build cant do a two-phase build&push, but thats what i need for semantic-release. I want to verifyt hat the image successfully builds (in prepare stage) before the actual release starts and the git commit & tag are pushed & GH release created. Because of that, i tried to build the image twice, once in prepare without --push-ing it, and then the second time in publish and then pushing it.
  2. I hoped that the second build would be coming from the cache, and we would only actually need to build it once. Something is busting that cache though, and only the first stage is used from the cache. Results in the image is actually built twice (per platform, so 4 times in total).
  3. Buildx is using qemu vms to build the image (unsure if that only happens on the cross-platform build, or for both platforms). And this is just plain slow in the github actions runners (which probably dont have any kind of nested virtualisation).
commented

Build time was reasonably optimized to ~10 minutes (from ~30 minutes) in #266