This repo has no snapshot tags or versioning so it is checked out at random commits
finagolfin opened this issue · comments
Now that it is enabled by default with swiftlang/swift#42611, it is past time it either had trunk snapshot tags or was checked out at some set version, rather than whatever the latest commit on the swift/main branch happens to be.
@shahmishal, I don't know if you need to set this up, or if the repo maintainers can.
@rxwei, you added this branch to the main repo in swiftlang/swift#41588, let me know what you think.
It's actually intentional that a developer needs to pull swift/main to build it with swift's main branch, which is exactly how it works with swift-driver and swift-tools-support-core.
That's fine for casual development, but both swift-driver and swift-tools-support-core provide snapshot tags, so that anyone building trunk or the 5.7 branch can check out those repos at a verified tag. Otherwise, you're stuck in a situation like with this repo, where if there are recent commits to swift/main, different devs are going to end up checking out different commits and potentially getting different results.
Ok I see what you mean. I think the snapshot tags should be set up. @shahmishal
Ping again, I'd like to build this repo as part of my daily Android CI, which downloads the latest Swift source snapshots and cross-compiles them for Android, but that requires more work to automate as long as this repo has no automated tags.
@rxwei, I see no commits to the swift/main branch in the last two months: maybe you can tag that last commit as a release and use it instead in the update-checkout script? Even if you don't change how that toolchain script checks this repo out, simply providing a tag will make it easier for downstream users like me to check it out.
Pinging @shahmishal again: it's been 7 months since this was added to the toolchain, it really should be tagged by version for trunk/5.8 or at least provide snapshot tags by now. I use the currently provided 5.7 release tags for my Android CI.
Sorry for the delay, this issue is resolved as of Jan 14 nightly toolchain.
Thanks, looking forward to using it.