make_public.py fails if the cluster file contains comments

[Sam Weaver]

The FoundationDB docs for the cluster file format specify that a cluster file can contain comments.

A cluster file may contain comments, marked by the # character. All characters on a line after the first occurrence of a # will be ignored.

Indeed, the coordinators FDB CLI command adds comments when writing an updated cluster file:

foundationdb/fdbclient/ClusterConnectionFile.actor.cpp

Lines 153 to 155 in 22a3ea8

 atomicReplace(filename, 
               "# DO NOT EDIT!\n# This file is auto-generated, it is not to be edited by hand\n" + 
                   cs.toString().append("\n")); 

However, when running make_public.py, the code to check for a valid cluster file fails to accommodate comments:

foundationdb/packaging/make_public.py

Lines 64 to 72 in 22a3ea8

 f = open(clusterFile, "r") 
 clusterStr = None 
 for line in f: 
     line = line.strip() 
     if len(line) > 0: 
         if clusterStr is not None: 
             invalidClusterFile(clusterFile) 
             return 
         clusterStr = line