Debian package missing Architecture metadata
rudihorn opened this issue · comments
This seems to be a regression of #6490.
Downloading the official foundationdb-server_7.3.7-1_amd64.deb and then running dpkg --info foundationdb-server_7.3.7-1_amd64.deb yields:
new Debian package, version 2.0.
size 51168796 bytes: control archive=2086 bytes.
61 bytes, 2 lines conffiles
536 bytes, 15 lines control
366 bytes, 6 lines md5sums
2301 bytes, 53 lines * postinst #!/bin/sh
1029 bytes, 27 lines * postrm #!/bin/sh
793 bytes, 23 lines * preinst #!/bin/sh
612 bytes, 16 lines * prerm #!/bin/sh
Architecture:
Depends: foundationdb-clients (= 7.3.7), adduser, libc6 (>= 2.12), foundationdb-clients (= 7.3.7)
Description: FoundationDB is a scalable, fault-tolerant, ordered key-value store with full ACID transactions.
FoundationDB is a scalable, fault-tolerant, ordered key-value store
with full ACID transactions.
.
Homepage: https://www.foundationdb.org
Maintainer: The FoundationDB Community
Package: foundationdb-server
Priority: optional
Recommends: python (>= 2.6)
Section: database
Version: 7.3.7
Installed-Size: 128962
Architecture should be amd64.
Still the case with 7.1.35
Long story short, this is my mistake. I have added it back to the environment for builds after 7.1.35 and 7.3.13.
I've also added a check in the release build process to verify that the arch is present in the package, It'll stop the process if it is missing. 🤞 this is the last time we re-visit this issue.
foundationdb_ci> dpkg --info foundationdb-server_7.1.37-1_amd64.deb
new debian package, version 2.0.
size 39076226 bytes: control archive=2055 bytes.
61 bytes, 2 lines conffiles
543 bytes, 15 lines control
316 bytes, 5 lines md5sums
2301 bytes, 53 lines * postinst #!/bin/sh
1029 bytes, 27 lines * postrm #!/bin/sh
793 bytes, 23 lines * preinst #!/bin/sh
612 bytes, 16 lines * prerm #!/bin/sh
Architecture: amd64
Depends: foundationdb-clients (= 7.1.37), adduser, libc6 (>= 2.12), foundationdb-clients (= 7.1.37)
Description: FoundationDB is a scalable, fault-tolerant, ordered key-value store with full ACID transactions.
FoundationDB is a scalable, fault-tolerant, ordered key-value store
with full ACID transactions.
.
Homepage: https://www.foundationdb.org
Maintainer: The FoundationDB Community
Package: foundationdb-server
Priority: optional
Recommends: python (>= 2.6)
Section: database
Version: 7.1.37
Installed-Size: 98952
I think the problem still exists on (at least) 7.2.[6-9] releases:
Run foundationdb-rs/foundationdb-actions-install@v2.1.0
Installing foundationdb 7.2.6 (linux)!
> curl -L -O https://github.com/apple/foundationdb/releases/download/7.2.6/foundationdb-clients_7.2.6-1_amd64.deb
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 71.1M 100 71.1M 0 0 220M 0 --:--:-- --:--:-- --:--:-- 220M
> sudo dpkg -i foundationdb-clients_7.2.6-1_amd64.deb
dpkg: warning: parsing file '/var/lib/dpkg/tmp.ci/control' near line 14 package 'foundationdb-clients':
empty value for 'Architecture' field
dpkg: error processing archive foundationdb-clients_7.2.6-1_amd64.deb (--install):
package architecture () does not match system (amd64)
Errors were encountered while processing:
foundationdb-clients_7.2.6-1_amd64.deb
Error: Command failed: sudo dpkg -i foundationdb-clients_7.2.6-1_amd64.deb
Does the fix has been backported to 7.2?
release-7.2 is an abandoned release branch, I will not be producing any further releases for it.
Oh, I wasn't aware of that. I think I can skip 7.2 support on the Rust binding. Thanks @ammolitor!