PageObjects gets elements API instead of element API

Question

PageObjects gets elements API instead of element API

saikrishna321 opened this issue 8 years ago · comments

Works fine

@HowToUseLocators(androidAutomation = CHAIN)
    @AndroidFindBySet({
            @AndroidFindBy(xpath = "(.//*[@resource-id='org.wordpress.android:id/note_content_container'])[position()=2]"),
            @AndroidFindBy(uiAutomator = "new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\")")
    }) //gets the third text from the note_subject view

Does not work

@HowToUseLocators(androidAutomation = CHAIN)
    @AndroidFindBySet({
            @AndroidFindBy(uiAutomator = "new UiSelector().resourceId(\"org.wordpress.android:id/note_content_container\").enabled(true).instance(2)"),
            @AndroidFindBy(uiAutomator = "new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\")")
    }) //return the first text from the view

https://gist.github.com/anonymous/d4440cab5e3213f9084498471201cd84

The above works fine, when we cast AndroidDriver

((AndroidDriver) driver).findElementByAndroidUIAutomator("new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\").enabled(true).instance(2)").getText()

https://gist.github.com/anonymous/3b1fcc5761c370a1025d52c42b60b9fd

Sergey Tikhomirov · Answer 1 · Fri Dec 30 2016 17:02:27 GMT+0800 (China Standard Time)

@saikrishna321
Please remove @AndroidFindBySet and check the result and use only AndroidFindBy :)

Sai Krishna · Answer 2 · Fri Dec 30 2016 17:04:12 GMT+0800 (China Standard Time)

@TikhomirovSergey giving it a try now.. What does @AndroidFindBySet do ?

Sergey Tikhomirov · Answer 3 · Fri Dec 30 2016 17:05:15 GMT+0800 (China Standard Time)

It makes AndroidFindBy repeatable.
http://docs.oracle.com/javase/tutorial/java/annotations/repeating.html

Sai Krishna · Answer 4 · Fri Dec 30 2016 17:07:51 GMT+0800 (China Standard Time)

@TikhomirovSergey still the same, it just gets the default first locator's text value

Sai Krishna · Answer 5 · Fri Dec 30 2016 17:08:49 GMT+0800 (China Standard Time)

https://gist.github.com/anonymous/cc08201899d52d47322604d3954817a3

Sergey Tikhomirov · Answer 6 · Fri Dec 30 2016 17:10:36 GMT+0800 (China Standard Time)

@saikrishna321
https://github.com/appium/java-client/blob/master/src/main/java/io/appium/java_client/pagefactory/AndroidFindBy.java#L34

Also if it is the chain by default you may not define
@HowToUseLocators(androidAutomation = CHAIN)

Please take a look at the updated WIKI chapter

Sergey Tikhomirov · Answer 7 · Fri Dec 30 2016 17:15:34 GMT+0800 (China Standard Time)

@saikrishna321
What happens when you try to

 driver.findElementByAndroidUIAutomator("new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\").enabled(true).instance(2)")
.findElementByAndroidUIAutomator("new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\")")

?

Sai Krishna · Answer 8 · Fri Dec 30 2016 17:17:14 GMT+0800 (China Standard Time)

 @AndroidFindBy(uiAutomator = "new UiSelector().resourceId(\"org.wordpress.android:id/note_content_container\").enabled(true).instance(2)"),
            @AndroidFindBy(uiAutomator = "new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\")")

public MobileElement getNotification;

With this as well the logs are same.

Here it picks the command with instance(3) https://gist.github.com/anonymous/cc08201899d52d47322604d3954817a3#file-updated-gist-with-androidfindby-L1132

and still looks for all elements
https://gist.github.com/anonymous/cc08201899d52d47322604d3954817a3#file-updated-gist-with-androidfindby-L1148-L1161

driver.findElementByAndroidUIAutomator("new UiSelector().resourceId("org.wordpress.android:id/note_subject").enabled(true).instance(2)").findElementByAndroidUIAutomator("new UiSelector().resourceId("org.wordpress.android:id/note_subject")")

It gives the Text at the Third view which is expected :)

Sergey Tikhomirov · Answer 9 · Fri Dec 30 2016 17:22:14 GMT+0800 (China Standard Time)

So does this code works well

 driver.findElementByAndroidUIAutomator("new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\").enabled(true).instance(2)")
.findElementByAndroidUIAutomator("new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\")")

?
Ok. Has the same happened before (v<5.0.0-BETAx)? If there is a client bug then it may be the old problem that should be fixed

Sai Krishna · Answer 10 · Fri Dec 30 2016 17:25:08 GMT+0800 (China Standard Time)

@TikhomirovSergey
This works

((AndroidDriver) driver).findElementByAndroidUIAutomator("new UiSelector().resourceId(\"org.wordpress.android:id/note_content_container\").enabled(true).instance(2)").
                findElement(MobileBy.AndroidUIAutomator("new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\")")).getText();

https://gist.github.com/saikrishna321/a156e5c88a9787c0794bca7646ec47cf

Yah, i just tried with 4.1.2 and its the same. Chaining with unique ID's works, but with uiAutomation does not. Looks like we need to fix

Sergey Tikhomirov · Answer 11 · Fri Dec 30 2016 17:27:38 GMT+0800 (China Standard Time)

Yep. I will try to search for the root cause on the 1 Jan. For now please use xpath instead.

Sai Krishna · Answer 12 · Fri Dec 30 2016 17:29:45 GMT+0800 (China Standard Time)

Cheers, this is required for the appium workshop(http://thoughtworks-bangalore.github.io/vodQA-Shots/) so will wait for the fix

Sergey Tikhomirov · Answer 13 · Fri Dec 30 2016 17:39:19 GMT+0800 (China Standard Time)

@saikrishna321
... and for your case it is enough

@AndroidFindBy(xpath = "(.//*[@resource-id='org.wordpress.android:id/note_content_container'])[position()=2]"),
@AndroidFindBy(uiAutomator = "new UiSelector().resourceId(\"org.wordpress.android:id/note_subject\")")
MobileElement element;

Sai Krishna · Answer 14 · Fri Dec 30 2016 17:50:17 GMT+0800 (China Standard Time)

@TikhomirovSergey its calling elements instead of element api, can you please help in pointing where we call this api

https://gist.github.com/anonymous/cc08201899d52d47322604d3954817a3#file-updated-gist-with-androidfindby-L1132

Sergey Tikhomirov · Answer 15 · Fri Dec 30 2016 17:58:02 GMT+0800 (China Standard Time)

yes.
It is here
https://github.com/appium/java-client/blob/master/src/main/java/io/appium/java_client/pagefactory/AppiumElementLocator.java#L157

I really think that root cause is here. But I can check it only tomorrow or on the 1 Jan.

Sai Krishna · Answer 16 · Fri Dec 30 2016 17:59:01 GMT+0800 (China Standard Time)

myself and @SrinivasanTarget are looking at it, if we break through will send a PR

Sergey Tikhomirov · Answer 17 · Fri Dec 30 2016 17:59:29 GMT+0800 (China Standard Time)

@saikrishna321
There were few reasons why it was designed that way. But I think it is outdated implementation for now.

Sergey Tikhomirov · Answer 18 · Fri Dec 30 2016 18:05:20 GMT+0800 (China Standard Time)

@saikrishna321

myself and @SrinivasanTarget are looking at it, if we break through will send a PR

Ok.
But please keep it in mind that it should be NowSuchElementException-safe till waiting time is expired.
Also please take a look at these classes from Selenium:
ByAll
ByChained

Could you please try this

driver.findElenent(new ByChained(...))

using your AndroidUIAtomator locators?