sign_apk broken with Fastlane 2.68.2: jarsigner -verbose -sigalg SHA1withRSA -digestalg SHA1: command not found
egr-ext opened this issue · comments
Hi,
With Fastlane 2.62, the command sign_apk works fine.
If I upgrade Fastlane to 2.68.2, I have an error :
jarsigner -verbose -sigalg SHA1withRSA -digestalg SHA1: command not found
What is the solution ?
+1
seems like cmd command is not executed in one line and .shellescape do not do the trick.
I'm not an expert in Ruby or Fastlane internals. In this case, seems to be that this command changed and it doesn't accept string arrays. Just change this line to:
Fastlane::Actions.sh(sign_cmd.join(" "), log: true)
and it will work again (at least for me :) )
I'm not a ruby guy at all but found exactly the same solution.
Fastlane::Actions.sh( sign_cmd.join(' '), log: true)
Thaks a lot, do we create a Pull Request ?
Just a heads up, the zipalign
action needs similar alterations (thanks to @monday8am for the original fix!):
zipalign.rb
Line 15: Fastlane::Actions.sh(rename_command.join(" "), log: false)
Line 18: Fastlane::Actions.sh(aligncmd.join(" "), log: true)
Hi everyone! We've noticed the activity here and would like you to know we'll be picking this up asap. Thanks for your input. Much appreciated!
The solutions outlined fixed the error "wrong first argument" which I got from both sign_apk and zipalign when using fastlane 2.69 and newer.