Giters

apostrophecms / seo

Add and manage SEO meta fields to all documents in ApostropheCMS.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Editing interface looks broken

pmeinhardt opened this issue · comments

commented

Hello 👋🙂 I was taking this plugin for a spin and noticed some weird behavior.

I am not sure whether this due to some interaction of the specific project setup with the plugin or an issue with the plugin itself.

I have an apostrophe (3.4.1) project with @apostrophecms/seo (1.0.0).

There's nothing that seems out-of-the-ordinary in the app config. Just widget options, an additional page type, and a few custom modules.

To Reproduce/Describe the bug

After following the setup instructions in the README:

  1. Not all SEO settings are grouped in the "SEO" tab (resolved)
  2. The links in the field help are not rendering properly
SEO settings Ungrouped settings
SEO settings Ungrouped settings

For reference, this is how the field and the help text are rendered:

<div data-v-4d52b6cc="" class="apos-field apos-field--string apos-field--seoTitle">
  <div data-v-4d52b6cc="" class="apos-field__info"><label data-v-4d52b6cc="" for="0.2537178649652405"
      class="apos-field__label">
      Title
      <!---->
      <!---->
      <!---->
    </label>
    <p data-v-4d52b6cc="" class="apos-field__help">//moz.com/learn/seo/title-tag" target="_blank"&gt;under 60
      characters.</p>
  </div>
  <div data-v-2979995a="" data-v-4d52b6cc="" class="apos-input-wrapper"><input data-v-2979995a="" data-v-4d52b6cc=""
      placeholder="" id="0.2537178649652405" tabindex="0" type="text" class="apos-input apos-input--text">
    <!---->
  </div>
  <!---->
</div>

Expected behavior

Regarding 1: I was expecting all SEO fields to be grouped in the SEO tab
Regarding 2: I suppose those //moz.com/learn/… elements should render as links

Details

Version of Node.js: 14.16.1
Server Operating System: macOS 11.6

commented

The first part of the issue – "Not all SEO settings are grouped in the 'SEO' tab – is resolved when updating to apostrophe@3.6.0. The second part is yet to be resolved.

commented

Had a moment to look into this a bit more. 🔬 It looks like the HTML help strings provided by this plugin trigger the issue that is described here: apostrophecms/apostrophe#3475

The seo and open-graph plugins are even mentioned there: apostrophecms/apostrophe#3475 (comment)

Looks like new releases that (hopefully 🤞) fix these issues are already underway:

Thanks @abea 💚

commented

This won't be resolved in the next release (today or tomorrow), but likely the next one. Sorry for the trouble. I will close this as a duplicate of apostrophecms/apostrophe#3475. Please follow that thread for updates.

commented

This won't be resolved in the next release (today or tomorrow), but likely the next one. Sorry for the trouble. I will close this as a duplicate of apostrophecms/apostrophe#3475. Please follow that thread for updates.

Thank you for the updates. 🙇🙂

commented

Sweet! 🍰 Updating to the latest package versions (apostrophe@3.7.0, @apostrophecms/seo@1.1.0 and @apostrophecms/open-graph@1.1.0) fixed the issue(s).

image