apollographql / federation-jvm

JVM support for Apollo Federation

Home Page:https://www.apollographql.com/docs/federation/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support for graphql-java version 17.+

golfingal72 opened this issue · comments

Can you please make a release that is compatible with graphql-java/graphql-java version 17.+
There are some breaking changes to the
graphql-java-support/src/main/java/com/apollographql/federation/graphqljava/FederationSdlPrinter.java

because the Directive GraphQLArgument object has changed, but the fixes can be found easily at:

https://github.com/graphql-java/graphql-java/blob/b525ada641bade0ea509669b28cb1920b33a2709/src/main/java/graphql/schema/idl/SchemaPrinter.java

since it appears this is basically a copy of that code to begin with.

The only other thing that failed was bootstrapping some of the spring tests which I did not spend the time to decode.

The new version of graphql has performance improvements that seem worthwhile. I am using Netflix DGS framework and in order for them to upgrade, there has to be a version of this library working with graphql-java V 17.+

Ahhh, I see you already have an Open PR for this that has been approved.

#122

do you have a release date on that?

Closed with #129 that update graphql-java to 17.3. It's available in version 0.7.0. Let us know how that works!