Can I add PX4 acro rate parameters to your awsome tool?
MaEtUgR opened this issue · comments
Story: Recently we started FPV racing the PX4 flight control firmware on pixracer boards. See https://docs.px4.io/en/frames_multicopter/qav_r_5_kiss_esc_racer.html
It has a lot of features like failsafes, got a lot better in racing performance with airmode, ... and started to support the low cost Omnibus F4 board which stacks onto the 4in1 Hobbywing ESC board.
Issue: The parameters for acro mode which you use for racing are a bit different from e.g. KISS on PX4, it's easier to tune because the values are more independent: you set the maximal rate which stays afterwards and then just shape the curve using expo and superexpo. But the rate stays and superexpo does not screw up expo...
Goal: Your comparing/converting tool is awsome! Am I allowed to add PX4 rates and link it in the official documentation? It should not be complicated, the formula is quite straight forward: https://www.desmos.com/calculator/yze23xmpqc
I would have already made a PR but I don't see where the apparently server side parameter conversions are done https://github.com/apocolipse/RotorPirates/blob/master/js/RotorPirates.js#L74-L80 Is that closed source or am I just blind?
Thanks in advance!
@MaEtUgR sorry for the late response, feel free to open a PR for displaying the rates. Keep the function similar to the others and I'll add it to the converter (converter itself is closed source)
@apocolipse Sounds good thanks! I will do that.