aphtoken / aph-wallet-gui

Aphelion wallet

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Assets should be per wallet instead of shared per network across all wallets

CryptoToit opened this issue · comments

Hi,

Running Wallet version 2.0.5 Logged in to my main address / account:

When I go to Assets and select a specific Token I then click on "Remove". I get a confirmation notification that the Token is removed, but it has not been removed from the lost. Also when I go to my Dashboard it is still there. Have tried this a couple times. Also logged out and back in and tired it again, same issue.

When I go to a different address / account the remove function works just fine. However, when I log back in all the tokens I removed is back showing again.

screen shot 2018-08-01 at 12 40 49

screen shot 2018-08-01 at 12 43 15

We had a bug where remove was sometimes being shown on assets on the dashboard. To remove tokens currently the wallet only supports this use case from the Assets page. I fixed the bug that was showing the remove button erroneously on the Dashboard, but that is peripheral to your issue.

This issue I describe do previouslt is fixed by e7da1f8

Currently your tokens are not per wallet. So opening a different wallet that has additional balances on tokens causes those tokens to get added for that network. Opening another wallet will then have those tokens added also. We need to make changes to keep tokens per wallet and per network instead of just per network.

I think this is the main issue you were addressing.

The tokens are now stored per wallet address so this issue should now be resolved.