aphalo / photobiology

Package ‘photobiology’ defines a system of classes for storing spectral data and accompanying methods and operators. This is the core of a suite of R packages for photobiological calculations.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

dplyr 1.0.8

romainfrancois opened this issue · comments

We're about to release dplyr 1.0.8 and it seems that the released version of photobiology has issues:

# photobiology

<details>

* Version: 0.10.8
* GitHub: https://github.com/aphalo/photobiology
* Source code: https://github.com/cran/photobiology
* Date/Publication: 2021-12-08 11:50:02 UTC
* Number of recursive dependencies: 60

Run `cloud_details(, "photobiology")` for more info

</details>

## Newly broken

*   checking examples ... ERROR
    ```
    Running examples in ‘photobiology-Ex.R’ failed
    The error most likely occurred in:
    
    > ### Name: A.illuminant.spct
    > ### Title: CIE A illuminant data
    > ### Aliases: A.illuminant.spct
    > ### Keywords: datasets
    > 
    > ### ** Examples
    > 
    > A.illuminant.spct
    Object: source_spct [97 x 2]
    Wavelength range 300 to 780 nm, step 5 nm 
    Label: CIE A standard illuminant, normalized to one at 560 nm 
    Time unit 1s
    Spectral data normalized to 1 at 560 nm 
    
    Error: 'trunc_mat' is not an exported object from 'namespace:dplyr'
    Execution halted
    ```

*   checking dependencies in R code ... WARNING
    ```
    Missing or unexported object: ‘dplyr::trunc_mat’
    ```

*   checking re-building of vignette outputs ... WARNING
    ```
    Error(s) in re-building vignettes:
    --- re-building ‘userguide-1-radiation.Rmd’ using rmarkdown
    News at https://www.r4photobiology.info/
    
    Attaching package: 'lubridate'
    
    The following objects are masked from 'package:base':
    
        date, intersect, setdiff, union
    
    ...
    
        date, intersect, setdiff, union
    
    --- finished re-building ‘userguide-2-astronomy.Rmd’
    
    SUMMARY: processing the following file failed:
      ‘userguide-1-radiation.Rmd’
    
    Error: Vignette re-building failed.
    Execution halted
    ```

it seems however fixed in the dev version.

It also seems to affect photobiologyInOut :

# photobiologyInOut

<details>

* Version: 0.4.23
* GitHub: https://github.com/aphalo/photobiologyinout
* Source code: https://github.com/cran/photobiologyInOut
* Date/Publication: 2021-10-11 04:10:01 UTC
* Number of recursive dependencies: 117

Run `cloud_details(, "photobiologyInOut")` for more info

</details>

## Newly broken

*   checking examples ... ERROR
    ```
    Running examples in ‘photobiologyInOut-Ex.R’ failed
    The error most likely occurred in:
    
    > ### Name: colorSpec2mspct
    > ### Title: Convert 'colorSpec::colorSpec' objects
    > ### Aliases: colorSpec2mspct as.source_spct.colorSpec
    > ###   as.source_mspct.colorSpec as.response_spct.colorSpec
    > ###   as.response_mspct.colorSpec as.filter_spct.colorSpec
    > ###   as.filter_mspct.colorSpec as.reflector_spct.colorSpec
    > ###   as.reflector_mspct.colorSpec as.chroma_mspct.colorSpec colorSpec2spct
    ...
    The following object is masked from ‘package:photobiology’:
    
        normalize
    
    Object: source_spct [93 x 2]
    Wavelength range 320 to 780 nm, step 5 nm 
    Time unit 1s
    
    Error: 'trunc_mat' is not an exported object from 'namespace:dplyr'
    Execution halted
    ```

*   checking re-building of vignette outputs ... WARNING
    ```
    Error(s) in re-building vignettes:
    --- re-building ‘user-guide.Rmd’ using rmarkdown
    News at https://www.r4photobiology.info/
    
    Attaching package: 'lubridate'
    
    The following objects are masked from 'package:base':
    
        date, intersect, setdiff, union
    
    ...
    Quitting from lines 525-530 (user-guide.Rmd) 
    Error: processing vignette 'user-guide.Rmd' failed with diagnostics:
    'trunc_mat' is not an exported object from 'namespace:dplyr'
    --- failed re-building ‘user-guide.Rmd’
    
    SUMMARY: processing the following file failed:
      ‘user-guide.Rmd’
    
    Error: Vignette re-building failed.
    Execution halted
    ```

## In both

*   checking dependencies in R code ... NOTE
    ```
    Namespace in Imports field not imported from: ‘lazyeval’
      All declared Imports should be used.
    ```

@romainfrancois It was easy enough in this case to remove the only call to trunc_mat() in package 'photobiology'. I have pushed the fix to GitHub. (The error in 'photobiologyInOut' was in a call to the same function from 'photobiology'.) When do you plan to submit 'dplyr' 1.0.8 to CRAN? How much time do I have to address other issues before submitting 'photobiology' to CRAN?

Probably this week, or early next week.

o.k., I will leave other changes for the next release.
Thanks!

'photobiology' 0.1.9' has passed CRAN checks and is now on its way to CRAN