apexcharts / Blazor-ApexCharts

A blazor wrapper for ApexCharts.js

Home Page:https://apexcharts.github.io/Blazor-ApexCharts

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Annotations multiline support - Solution proposal

peterboccia opened this issue · comments

Hi all,

after a lot of research I found out that ApexCharts has changed the annotations to support multiline.
I tried all before: \n,
etcetera, but neither works. And the problem was: in the annotation (X or Y indiscriminately) the property text is use to hold string or array of strings if you want multiple lines to show.
Unfortunately in C# we don't have the discriminated union so we need to choose: object to handle everything and put a comment on it, or directly use a List as type.
I made the changes as List and it worked: samples of annotations still work as before, added a new one to handle two lines and works as expected.
Maybe, it could be easier to handle an object because this would affects the retro-compatibility of the library.
I'll make the changes and push the PR.
Thanks in advance for you attention

Joadan sorry I just noticed that the last version was not published. I also realized I should also update the version number to make the publish work correctly. Can we address this problem?

Hi,

Your PR has been accepted and merge into the main branch.
I will prepare a release in a couple of days.