Standard Mode Misaligned
apearson opened this issue · comments
Noted here
Someone should go back and make sure Condensed mode is aligned properly.
Idea from betatester:
did you try to superimpose Standard color picker screenshot with reduced opacity over the Condensed one to see if there's an uneven X Y axes shift?
@blindingstars
We should retest. I just tried both #000000 and #464646 on my phone and got a perfect match
@AndrewPE - this is seekweb from reddit -- thanks for the invite! I'll take a look at this issue as well, but please note that I'm traveling today and Friday for work. Thanks again! - Scott
Still off for me; the following should be #000000; still yielding #070707.
I see what the problem is but I can't replicate it on my device. I feel like the standard display on the edge is different from the standard display on the flat. If there is a way to get on a screen sharing session going we can get this problem worked out.
Not a bad idea! I'm unfortunately going to be traveling and occupied tomorrow and over the weekend, but I'd be happy to screenshare on Monday. I work from home, so super-flexible as long as it's not from 10-10:30a Central.
Sounds good! There's no way you could get me a full size screenshot and the output of the program when you use #000000 is there?
Here's the full-size! I can get you the output once I'm back in for the evening.
python hex2goodlock.py "#464646"
Input Hex: #464646
HSV
(0.0, 0.0, 0.27450980392156865)
Display Mode: Condensed
Hue Screen Location: 860x924
Saturation Screen Location: 249px
Value Screen Location: 1262px
adb shell input tap 860 924 && adb shell input tap 249 1262
python hex2goodlock.py "#464646"
Input Hex: #464646
HSV
(0.0, 0.0, 0.27450980392156865)
Display Mode: Condensed
Hue Screen Location: 860x924
Saturation Screen Location: 249px
Value Screen Location: 1262px
adb shell input tap 860 924 && adb shell input tap 249 1262
is the output. I noticed that it is saying my display mode is condensed, which is incorrect.
Thanks @blindingstars that put me on the right track. I believe it was the screen type detection method I was using. I've upgrade the detection method to be a little bit smarter in d39440e!
Tests from other beta testers seem promising! It sounds like this commit fixed the problem. @blindingstars once you test on your device then we'll close this issue.
💥 Works perfectly now with every color I've tossed at it! Nicely done!
Perfect!