Off-by-one error causes protocol corruption

Question

Off-by-one error causes protocol corruption

Chickenzilla opened this issue 3 years ago · comments

https://github.com/apache/pulsar-dotpulsar/blob/master/src/DotPulsar/Internal/Extensions/ReadOnlySequenceExtensions.cs#L91 can cause some sequences to be only partially read, returning incorrect length values and causing protobuf errors. I have implemented a fix in our fork along with enhanced unit tests that show the issue at mParticle@f13e312.

Daniel Blankensteiner · Answer 1 · Fri Apr 30 2021 03:23:19 GMT+0800 (China Standard Time)

Hi @Chickenzilla
Thanks, I'll look into it! :-)

Daniel Blankensteiner · Answer 2 · Fri Apr 30 2021 03:52:46 GMT+0800 (China Standard Time)

Hi @Chickenzilla
Looking good and great work with the tests! :-)
Wanna create a PR for the changes to ReadOnlySequenceExtensions and ReadOnlySequenceExtensionsTests or should I just go ahead with a copy/paste?

Tim Corbett · Answer 3 · Fri Apr 30 2021 05:50:20 GMT+0800 (China Standard Time)

Please handle it yourself (feel free to take any/all code from my PR as desired). I've moved onto a different bug and won't have time to come back to this for at least a few days.

Daniel Blankensteiner · Answer 4 · Fri Apr 30 2021 13:39:01 GMT+0800 (China Standard Time)

I have just released 1.0.2 that fixes this.