Giters

apache / incubator-answer

A Q&A platform software for teams at any scales. Whether it's a community forum, help center, or knowledge management platform, you can always count on Apache Answer.

Home Page:https://answer.apache.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unable to attach a Particular tag to a question - it getting override to different TAG

surapuramakhil opened this issue · comments

commented

Describe the bug

Check video

REC-20240401054037.mp4

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots or video to help explain your problem.

Platform

  • Device: [e.g. Desktop, Mobile]
  • OS: [e.g. macOS]
  • Browser and version: [e.g. Chrome, Safari]
  • Version: [e.g. v1.2.0]
commented

@surapuramakhil Thanks for feedback. This is may because did not format the slug name when updating the tags. PUT /tag API. Regular the tag slug name should not have spaces, and spaces will be replaced with a hyphen.

commented

Ah, It's interesting. I checked slug data of these tags. Surprised, only this slug has spaces instead of -. Wondering why had happened.

Thanks, @LinkinStars. Based on information provided, I was able to clean up tags and the issue has been fixed after cleanup.

commented

Hello I would like to take a crack at this bug. @LinkinStars what would be the ideal behaviour in this case?

commented

Hello I would like to take a crack at this bug. @LinkinStars what would be the ideal behaviour in this case?

@prithvidasgupta Good. Let me describe the problem indetail.

In /tag POST API service, the one used to add a tag, you can see that there is formatting for the tag's slug_name.

incubator-answer/internal/service/tag_common/tag_common.go

Lines 324 to 325 in 8670e33

SlugName := strings.ReplaceAll(req.SlugName, " ", "-")
SlugName = strings.ToLower(SlugName)

In /tag PUT API service, the one used to update the tag, you can see that there is no formatting.

incubator-answer/internal/service/tag_common/tag_common.go

Line 822 in 8670e33

func (ts *TagCommonService) UpdateTag(ctx context.Context, req *schema.UpdateTagReq) (err error) {

So, just add the same formatting code to the PUT API service.

BTW, the SlugName should be slugName. You can fix the typo at the same time.

commented

@LinkinStars #923 should be the exact code change as you suggested. I tested it by running the build locally but I am not sure where to add the unit-tests.