Giters

apache / dolphinscheduler

Apache DolphinScheduler is the modern data orchestration platform. Agile to create high performance workflow with low-code

Home Page:https://dolphinscheduler.apache.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[DSIP-34] Change required_approving_review_count to 2

ruanwenjun opened this issue · comments

commented

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

Right now, the minimal approve count is 1 in DS, this means once a pr receive an approve, then this PR can be merged. In fact, in most of merged PR, the approval is one.

While I don't agree with change the minimal ap to 2, currently only 1 ap can merge PRs leading to a lot of PRs being merged in a hurry. This make the project get a lot of changes only a small number of people(Maybe only one people) want.

So it's need to change the required_approving_review_count be larger than one.

Design Detail

Change required_approving_review_count in .asf.yaml

Compatibility, Deprecation, and Migration Plan

Compatibility

Test Plan

No

Code of Conduct